GODRIVER-2603 (Contd.) Revised error handling using Go 1.13 error APIs #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumarlokesh
requested review from
prestonvasquez
and removed request for
a team
API Change ReportNo changes found! |
prestonvasquez
requested changes
Dec 6, 2023
There was a problem hiding this comment.
Thanks for the additional work on error handling @kumarlokesh !
kumarlokesh
force-pushed
the
GODRIVER-2603-3
branch
2 times, most recently
from
83c18e2
to
d740b71
Compare
kumarlokesh
force-pushed
the
GODRIVER-2603-3
branch
from
d740b71
to
6612270
Compare
|
@prestonvasquez I tried the automatic backport but it looks like there are conflicts from #1486 that I didn't know how to resolve myself. You can run: git pull upstream v1
git create -b GODRIVER-2603 upstream/v1
git cherry-pick -x 4dbe540And then handle the merge conflicts. |
qingyang-hu
pushed a commit
to qingyang-hu/mongo-go-driver
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2603
Summary
Follow-up PR to #1470 and #1476
Background & Motivation
As a requirement for the related ticket GODRIVER-2646, all errors are required to
be addressed to enable errorlint linter.
Would submit subsequent PR(s) to fix remaining errors before
errorlintlintercould be enabled.