GODRIVER-2960 Improve Evergreen Runtime and Usability #1472
Conversation
API Change ReportNo changes found! |
blink1073
requested review from
prestonvasquez
and removed request for
a team
| @@ -166,7 +166,7 @@ functions: | |||
| . ${DRIVERS_TOOLS}/.evergreen/venv-utils.sh | |||
| . ${DRIVERS_TOOLS}/.evergreen/find-python3.sh | |||
|
|
|||
| export PYTHON3_BINARY="$(find_python3)" | |||
| export PYTHON3_BINARY="$(find_python3 2>/dev/null)" | |||
There was a problem hiding this comment.
What is the reason for discarding error messages when running find_python3?
There was a problem hiding this comment.
That's the recommended usage pattern, it prints debug info to stderr.
.evergreen/config.yml
Outdated
| @@ -203,6 +203,19 @@ functions: | |||
| content_type: application/x-gzip | |||
| display_name: "fuzz.tgz" | |||
|
|
|||
| upload-raw-test-suite: | |||
There was a problem hiding this comment.
IIUC the reason this function is not in the upload-mo-artifacts's command array is that this needs to be used in multiple tasks. Is it possible that those cases result in workflows that do not call the post functions?
There was a problem hiding this comment.
Good point, I grouped them together and renamed it to handle-test-artifacts, since we're already uploading the fuzz file there.
.evergreen/config.yml
Outdated
| aws_secret: ${aws_secret} | ||
| local_file: src/go.mongodb.org/mongo-driver/test.suite | ||
| optional: true | ||
| remote_file: ${UPLOAD_BUCKET}/${build_variant}/${revision}/${version_id}/${build_id}/logs/${task_id}-${execution}-test.suite.txt |
There was a problem hiding this comment.
Tar'ing the test.suite.txt file before PUT would result in a faster upload.
| mongo-orchestration stop | ||
| cd - | ||
| rm -rf $DRIVERS_TOOLS || true | ||
| bash ${DRIVERS_TOOLS}/.evergreen/stop-orchestration.sh |
There was a problem hiding this comment.
The tools script for stop-orchestration.sh doesn't include the logic that removes the drivers tools clone:
cd -
rm -rf $DRIVERS_TOOLS || trueIs this worth retaining as part of the cleanup?
|
Note that we need to wait for https://jira.mongodb.org/browse/DEVPROD-2629 to verify uploads are working. |
| @@ -196,12 +200,31 @@ functions: | |||
| params: | |||
| aws_key: ${aws_key} | |||
| aws_secret: ${aws_secret} | |||
| optional: true | |||
There was a problem hiding this comment.
Are there cases where the test suite does not occur?
There was a problem hiding this comment.
The lambda test and the ECS test don't.
GODRIVER-2960
Summary
test_suite.tgzfile even in failure so we see the reason.Background & Motivation
Improve Evergreen Runtime and Usability.