Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GODRIVER-2824 Remove non-int64 Exported Connection IDs #1459

Merged
merged 1 commit into from
Nov 7, 2023
Merged

GODRIVER-2824 Remove non-int64 Exported Connection IDs #1459

merged 1 commit into from
Nov 7, 2023

Conversation

prestonvasquez
Copy link
Collaborator

GODRIVER-2824

Summary

  • Change PoolEvent.ConnectionID to an int64.
  • Rename the deprecated ServerConnectionID64 to ServerConnectionID on CommandStartedEvent and CommandFinishedEvent.
  • Update the internal representation of the connection pool's connection ID to int64 (from uint64).

Background & Motivation

GODRIVER-2737 changes the connection ID types on events to int64. To avoid breaking changes in the v1 driver, we deprecated the old ServerConnectionID fields in favor of ServerConnectionID64.

@prestonvasquez prestonvasquez requested a review from a team as a code owner November 6, 2023 22:42
@prestonvasquez prestonvasquez requested review from blink1073 and removed request for a team November 6, 2023 22:42
@prestonvasquez prestonvasquez changed the base branch from v1 to master November 6, 2023 22:42
@mongodb-drivers-pr-bot mongodb-drivers-pr-bot
Copy link
Contributor

API Change Report

./event

incompatible changes

CommandFailedEvent.ServerConnectionID64: removed
CommandFinishedEvent.ServerConnectionID64: removed
CommandStartedEvent.ServerConnectionID64: removed
CommandSucceededEvent.ServerConnectionID64: removed
ConnectionCheckOutFailed: removed
ConnectionCheckOutStarted: removed
ConnectionCheckedIn: removed
ConnectionCheckedOut: removed
PoolEvent.ConnectionID: changed from uint64 to int64

compatible changes

CommandFailedEvent.ServerConnectionID: added
CommandFinishedEvent.ServerConnectionID: added
CommandStartedEvent.ServerConnectionID: added
CommandSucceededEvent.ServerConnectionID: added
ConnectionReturned: added
GetFailed: added
GetStarted: added
GetSucceeded: added

./x/mongo/driver

incompatible changes

Connection.DriverConnectionID: changed from func() uint64 to func() int64

./x/mongo/driver/drivertest

incompatible changes

(*ChannelConn).DriverConnectionID: changed from func() uint64 to func() int64

./x/mongo/driver/session

incompatible changes

LoadBalancedTransactionConnection.DriverConnectionID: changed from func() uint64 to func() int64

./x/mongo/driver/topology

incompatible changes

(*Connection).DriverConnectionID: changed from func() uint64 to func() int64

blink1073
blink1073 approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

qingyang-hu
qingyang-hu approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prestonvasquez prestonvasquez merged commit 9fd0424 into mongodb:master Nov 7, 2023
37 checks passed
@prestonvasquez prestonvasquez deleted the GODRIVER-2824 branch November 7, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingyang-hu qingyang-hu qingyang-hu approved these changes

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prestonvasquez @blink1073 @qingyang-hu