Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GODRIVER-2046 Return clearer error when truncating a float64 to float32 #1439

Closed
wants to merge 1 commit into from
Closed

GODRIVER-2046 Return clearer error when truncating a float64 to float32 #1439

wants to merge 1 commit into from

Conversation

ehershey
Copy link
Contributor

GODRIVER-2046

Summary

Update error text.

Background & Motivation

Just ran into this today and it caused me a little friction. It seems like a simple enough fix.

@ehershey ehershey requested a review from a team as a code owner October 22, 2023 16:43
@ehershey ehershey requested review from prestonvasquez and removed request for a team October 22, 2023 16:43
@ehershey ehershey changed the title GODRIVER-2046 Return clearer error when truncating a float64 to float… GODRIVER-2046 Return clearer error when truncating a float64 to float32 Oct 22, 2023
@mongodb-drivers-pr-bot
Copy link
Contributor

API Change Report

No changes found!

@prestonvasquez prestonvasquez changed the base branch from master to v1 October 30, 2023 15:40
@prestonvasquez prestonvasquez changed the base branch from v1 to master October 30, 2023 15:40
prestonvasquez
prestonvasquez requested changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@prestonvasquez prestonvasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehershey Can you rebase these changes to v1? We use the master branch for development.

@ehershey
Copy link
Contributor Author

ehershey commented Nov 1, 2023 •
edited
Loading

Sure @prestonvasquez! Although, sorry, I didn't realize until just now that I could change the target branch on this PR. I opened #1448 instead. Can we use that PR and close this one? Or I can force push to my GODRIVER-2046 branch and use this PR if that's preferable for some reason. Thanks!

@prestonvasquez
Copy link
Collaborator

Sure @prestonvasquez! Although, sorry, I didn't realize until just now that I could change the target branch on this PR. I opened #1448 instead. Can we use that PR and close this one? Or I can force push to my GODRIVER-2046 branch and use this PR if that's preferable for some reason. Thanks!

Sure, that works.

@prestonvasquez
Copy link
Collaborator

Closing in favor of #1448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvasquez prestonvasquez prestonvasquez requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehershey @prestonvasquez