Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GODRIVER-2952 Update context.Canceled equality comparisons to errors.Is #1413

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

ramitmittal
Copy link
Contributor

GODRIVER-2952

Summary

Updated instances of ctx.Err() == context.Cancelled || ctx.Err() == context.DeadlineExceeded with calls to errors.Is()

Background & Motivation

This is a more idiomatic way of checking error types.

@ramitmittal ramitmittal requested a review from a team as a code owner October 5, 2023 18:28
@ramitmittal ramitmittal requested review from blink1073 and removed request for a team October 5, 2023 18:28
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 9ca46ea into mongodb:master Oct 6, 2023
31 of 38 checks passed
prestonvasquez pushed a commit to prestonvasquez/mongo-go-driver that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants