GODRIVER-2690 Set minimum supported Go version to 1.18 in Go Driver v2.0 #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
commented
Sep 14, 2023
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
requested review from
blink1073 and
matthewdale
and removed request for
a team
prestonvasquez
commented
Sep 14, 2023
| @@ -41,7 +41,7 @@ func BenchmarkClientWrite(b *testing.B) { | |||
| if err != nil { | |||
| b.Fatalf("error connecting: %v", err) | |||
| } | |||
| defer client.Disconnect(context.Background()) | |||
| defer func() { _ = client.Disconnect(context.Background()) }() | |||
There was a problem hiding this comment.
golangci-lint wants us to check errors.
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
matthewdale
reviewed
Sep 15, 2023
benchmark/bson.go
Outdated
| @@ -11,7 +11,7 @@ import ( | |||
| "io/ioutil" | |||
| "path/filepath" | |||
|
|
|||
| "go.mongodb.org/mongo-driver/bson" | |||
| "go.mongodb.org/mongo-driver/v2/bson" | |||
There was a problem hiding this comment.
I'm concerned that doing this package major version bump now is going to make keeping v1 and master in-sync difficult for the duration of v2 development. That may cause every v1 --> master sync to hit a merge conflict or require manual modification of the import path. Is it possible to defer making the module version change until later?
There was a problem hiding this comment.
Yep, this makes sense. I will revert those changes.
|
That's quite a diff summary 🎉 |
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
API Change ReportNo changes found! |
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
matthewdale
previously approved these changes
Sep 18, 2023
Makefile
Outdated
| .PHONY: check-modules | ||
| check-modules: | ||
| go mod tidy -v | ||
| go mod vendor | ||
| git diff --exit-code go.mod go.sum ./vendor | ||
| go mod verify |
There was a problem hiding this comment.
Optional: go mod verify seems to conflict with using Go workspaces in some cases (see golang/go#62663). When I run that command on my workstation, I get an error:
❯ go mod verify
go.mongodb.org/mongo-driver : missing ziphash: open hash: no such file or directory
Consider removing go mod verify.
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
blink1073
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2690
Summary
Migrate the Go imports and module to v2 and set minimum supported Go Version to 1.18. Additionally, updating to 1.18 allows us to remove the vendor directory.
Background & Motivation
The Go Driver team intends for the master branch to work as the "development" branch. Therefore, a "v1" branch has been cut where v1.x-focused tickets will be development on the "v1" branch and then cherry-picked , as needed, to the master branch.
This ticket updates the master branch to reflect the "development" branch as v2-focused.