GODRIVER-2963 Use more environment variables in Azure KMS test #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may prevent future code changes if Azure test data changes.
kevinAlbs
changed the title
qingyang-hu
reviewed
Aug 30, 2023
cmd/testkms/main.go
Outdated
Comment on lines
56
to
57
| azurekms_key_name := os.Getenv("AZUREKMS_KEY_NAME") | ||
| azurekms_key_vault_endpoint := os.Getenv("AZUREKMS_KEY_VAULT_ENDPOINT") |
There was a problem hiding this comment.
Optional: Maybe, we can put these two lines under the if provider == "azure" condition.
qingyang-hu
approved these changes
Aug 30, 2023
kevinAlbs
added a commit
that referenced
this pull request
Aug 30, 2023
* use environment variables for key_name and key_vault_endpoint This may prevent future code changes if Azure test data changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2963
Summary
keyNameandkeyVaultVndpointin the Azure KMS test.Changes were verified with this patch: https://spruce.mongodb.com/version/64ee53e7c9ec449533606004
Background & Motivation
The
test-azure-kmstask currently uses credentials and data from a personal MongoDB account.DRIVERS-2709 gives MongoDB managed credentials for the Azure KMS tests.
AZUREKMS_KEY_NAMEandAZUREKMS_KEY_VAULT_ENDPOINTwere added as Variables to the Evergreen Projects:mongo-go-driver-cloudmongo-go-drivermongo-go-driver-releasemongo-go-driver-previousThe old values were used. After this PR is merged, the Variables can be migrated to the new MongoDB managed values.