-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GODRIVER-2962 Remove setters from Command. #1364
GODRIVER-2962 Remove setters from Command. #1364
Conversation
API Change Report./x/mongo/driver/operationincompatible changes(*Command).ClusterClock: removed compatible changesCommand.Clock: added |
The base branch was changed.
934fba2
to
ff57da9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a v2 change? GODRIVER-2962 is not part of the 2.0 epic, but this PR is pointing at master.
@prestonvasquez no, this is not a strictly v2 change. I switched the branch to minimize the additional work required to sync changes from |
Closing this for now, will follow up later when GODRIVER-2962 is scheduled. |
GODRIVER-2962
Summary
Remove setters from
Command
.Background & Motivation
The field setters on the operation types in the
x/mongo/driver/operation
package provide no usability improvement but create a maintenance burden whenever we have to update the operations. Remove the field setters and use struct literals instead.Split the change into multiple PRs to make reviewing them easier.