Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GODRIVER-2943 Skip failing logging tests #1350

Merged
merged 6 commits into from
Aug 16, 2023
Merged

GODRIVER-2943 Skip failing logging tests #1350

merged 6 commits into from
Aug 16, 2023

Conversation

blink1073
Copy link
Member

GODRIVER-2943

Summary

Skip failing logging test for now, to be picked up in Green Build.

Background & Motivation

Get builds green in PRs to avoid masking other errors.

@blink1073 blink1073 requested a review from a team as a code owner August 15, 2023 11:20
@blink1073 blink1073 requested review from qingyang-hu and removed request for a team August 15, 2023 11:20
@blink1073
Copy link
Member Author

Huh, I accidentally pushed the branch to upstream, which is why the PR report fails.

qingyang-hu
qingyang-hu reviewed Aug 15, 2023
View reviewed changes
mongo/integration/unified_spec_test.go Outdated
@@ -61,6 +62,7 @@ var (
"CreateCollection from encryptedFields.": godriver2413SkipReason,
"DropCollection from encryptedFields": godriver2413SkipReason,
"DropCollection from remote encryptedFields": godriver2413SkipReason,
"Topology LifeCycle": godriver2943SkipReason,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a description of "Topology LifeCycle" used in any spec test?
Also, did you run the "go fmt" to help align the key-value pair? EG "static-analysis" is complaining about the format. You may find some IDE plugins to format the lines automatically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it should be Topology lifecycle:

mongo/integration/unified_spec_test.go:             "Topology lifecycle":                               godriver2943SkipReason,
testdata/server-discovery-and-monitoring/unified/logging-loadbalanced.json:      "description": "Topology lifecycle",
testdata/server-discovery-and-monitoring/unified/logging-loadbalanced.yml:  - description: "Topology lifecycle"
testdata/server-discovery-and-monitoring/unified/logging-replicaset.json:      "description": "Topology lifecycle",
testdata/server-discovery-and-monitoring/unified/logging-replicaset.yml:  - description: "Topology lifecycle"
testdata/server-discovery-and-monitoring/unified/logging-sharded.json:      "description": "Topology lifecycle",
testdata/server-discovery-and-monitoring/unified/logging-sharded.yml:  - description: "Topology lifecycle"
testdata/server-discovery-and-monitoring/unified/logging-standalone.json:      "description": "Topology lifecycle",
testdata/server-discovery-and-monitoring/unified/logging-standalone.yml:  - description: "Topology lifecycle"

qingyang-hu
qingyang-hu approved these changes Aug 15, 2023
View reviewed changes
Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blink1073
Copy link
Member Author

Hmm, it isn't actually skipping the test yet...

@blink1073 blink1073 marked this pull request as draft August 15, 2023 14:26
prestonvasquez
prestonvasquez reviewed Aug 15, 2023
View reviewed changes
mongo/integration/unified_spec_test.go Outdated
@@ -61,6 +62,7 @@ var (
"CreateCollection from encryptedFields.": godriver2413SkipReason,
"DropCollection from encryptedFields": godriver2413SkipReason,
"DropCollection from remote encryptedFields": godriver2413SkipReason,
"Topology_lifecycle": godriver2943SkipReason,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not contain an underscore, it should be "Topology lifecycle"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests weren't skipped with "Topology lifecycle" either.

Copy link
Collaborator

@prestonvasquez prestonvasquez Aug 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see. This is for the legacy unified spec test runner. The SDAM tests where "Topology lifecycle" is defined is for the unified spec runner, which is tested here. This is the map that should be extended.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you include a comment with the greener build ticket?

// GODRIVER-2943: Fix failing logging tests

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@blink1073 blink1073 marked this pull request as ready for review August 16, 2023 14:26
qingyang-hu
qingyang-hu approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@qingyang-hu qingyang-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! TIL

@blink1073 blink1073 merged commit 20f8121 into master Aug 16, 2023
1 check failed
@blink1073 blink1073 deleted the GODRIVER-2943 branch August 16, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qingyang-hu qingyang-hu qingyang-hu approved these changes

@prestonvasquez prestonvasquez Awaiting requested review from prestonvasquez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blink1073 @prestonvasquez @qingyang-hu