DOP-4264 #966
Merged
DOP-4264 #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your feature branch infrastructure has been deployed! Your webhook URL is: https://buzlgzj8cd.execute-api.us-east-2.amazonaws.com/prod/webhook/githubEndpoint/trigger/build For more information on how to use this endpoint, follow these instructions. |
mmeigs
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: noticed an unwanted outcome in persistence module when merging ToC's - A merged metadata entry for an associated product would have the full
urloption, instead of having theslugoption to navigate to related pages. This was due to mutation of the originally referenced node, where it mutates previously stored values as well.Example of entry here (see entry for _id: ObjectId('65a81d3ab914fa9f351aee3c') in snooty_dotcomstg.metadata)
The above ToC nodes should have a
slugfield (as opposed tourlfield) since this is a metadata entry for atlas-cliTo mitigate this issue, added a line to structuredClone that is available since node v17. Updated the git test and nvm versions accordingly