[DOP-4097]: Ensure we use the --no-caching flag for production builds #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The URL for your feature branch webhook is https://obrs6yxld6.execute-api.us-east-2.amazonaws.com/prod/ |
branberry
changed the title
seungpark
approved these changes
Nov 22, 2023
| @@ -18,5 +23,9 @@ export async function nextGenParse({ repoDir, patchId, commitHash }: NextGenPars | |||
| commandArgs.push(patchId); | |||
| } | |||
|
|
|||
| if (isProd) { | |||
There was a problem hiding this comment.
IIUC, this is for when we do use this export fn nextGenParse for prod, since this is not being used yet. can we add a comment for this?
src/job/stagingJobHandler.ts
Outdated
| @@ -60,6 +60,7 @@ export class StagingJobHandler extends JobHandler { | |||
|
|
|||
| prepStageSpecificNextGenCommands(): void { | |||
| if (this.currJob.buildCommands) { | |||
| // TODO: Remove no-caching after done testing | |||
mmeigs
approved these changes
Nov 22, 2023
rayangler
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
DOP-4097
Notes
To verify, I have added the flag for staging jobs to ensure that the flag is passed into the makefile without error. Here is a link to a job that has run with the
--no-cachingflag.The shared.mk PR can be found here.