Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-5065: add redirect rule for compass - master #1073

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

seungpark
Copy link
Contributor

@seungpark seungpark commented Oct 8, 2024

Stories/Links:

DOP-5065

Notes

  • We have a maximum of 50 redirect rules. We are approaching this (47 at this bucket) and will need to resort to object redirects at 50.
  • From AWS docs, it looks like a trailing slash is preferred, but wondering why we don't have trailing slashes for redirect prefix rules. I've included them in the change, but can make this change bigger to the existing redirects. This has caused issues before (ie. bad redirects from bi-connector versions)

Tested in staging env:
https://mongodbcom-cdn.website.staging.corp.mongodb.com/docs-qa/compass/master
With redirect rules showing:

{
        "Condition": {
            "KeyPrefixEquals": "docs-qa/compass/master/"
        },
        "Redirect": {
            "HostName": "mongodbcom-cdn.website.staging.corp.mongodb.com",
            "Protocol": "https",
            "ReplaceKeyPrefixWith": "docs-qa/compass/current/"
        }
    }

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

@seungpark seungpark requested review from i80and and branberry October 8, 2024 20:56
Copy link

github-actions bot commented Oct 8, 2024

Your feature branch infrastructure has been deployed!

Your webhook URL is: https://cvv7cjej37.execute-api.us-east-2.amazonaws.com/prod/webhook/githubEndpoint/trigger/build

For more information on how to use this endpoint, follow these instructions.

@seungpark seungpark merged commit f00f509 into main Oct 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants