Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOP-4549 (hotfix) #1044

Merged
merged 2 commits into from
May 9, 2024
Merged

DOP-4549 (hotfix) #1044

merged 2 commits into from
May 9, 2024

Conversation

anabellabuckvar
Copy link
Contributor

@anabellabuckvar anabellabuckvar commented May 9, 2024 •
edited
Loading

Stories/Links:

DOP-4549

Notes

This PR implements additional error checking, after it was discovered that the recently merged PR will cause the slack modal not to appear if a user has a bad entitlement.

README updates

    • This PR introduces changes that should be reflected in the README, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README

@anabellabuckvar anabellabuckvar marked this pull request as ready for review May 9, 2024 20:52
mmeigs
mmeigs approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. LGTM! Thanks for catching

@anabellabuckvar anabellabuckvar merged commit 01223b9 into main May 9, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmeigs mmeigs mmeigs approved these changes

@seungpark seungpark Awaiting requested review from seungpark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anabellabuckvar @mmeigs