Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-46812 - Type Hints and Client Params #156

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Jan 28, 2025

Started documenting type hints and realized we'd need MongoClient constructor params in order to describe everything. This first review is just the MongoClient page.

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-46869 and https://jira.mongodb.org/browse/DOCSP-46812

Staging Links

  • connect/mongoclient
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Jan 28, 2025

    Deploy Preview for docs-pymongo ready!

    Name Link
    🔨 Latest commit c4e5620
    🔍 Latest deploy log https://app.netlify.com/sites/docs-pymongo/deploys/6799587473375c00082c7455
    😎 Deploy Preview https://deploy-preview-156--docs-pymongo.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    Copy link
    Collaborator

    @stephmarie17 stephmarie17 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM!

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants