Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-46445-Compass-1.45.1-Release-Notes #709

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

jmd-mongo
Copy link
Collaborator

@jmd-mongo jmd-mongo commented Jan 15, 2025

DESCRIPTION

Compass 1.45.1 Release Notes.

STAGING

https://deploy-preview-709--docs-compass.netlify.app/release-notes/#compass-1.45.1

JIRA

https://jira.mongodb.org/browse/DOCSP-46445

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for docs-compass ready!

Name Link
🔨 Latest commit d98eeb7
🔍 Latest deploy log https://app.netlify.com/sites/docs-compass/deploys/67895ee530c44f00086470d8
😎 Deploy Preview https://deploy-preview-709--docs-compass.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

- Don't cut off list view value editor tooltips (:issue:`COMPASS-8581`)
- Fixes element key editor tooltip and revert not updating validity
(:issue:`COMPASS-8586`)
- Don't fallback to zero if the count cannot be determined
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question for tech reviewer]

Does this have an associated issue #? I don't see one listed here: https://github.com/mongodb-js/compass/releases/tag/v1.45.1 Should we consider removing this? Thanks!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added COMPASS-8841 for this

Copy link
Collaborator

@kennethdyer kennethdyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmd-mongo, LGTM!

Comment on lines 20 to 21
- Adds welcome page (:issue:`COMPASS-8657`)
- Adds onFailToLoadConnections callback (:issue:`COMPASS-8657`)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this two features are part of CompassWeb and currently we do not include them in the release notes. I know this came from GH release notes, however can we drop them?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

- Don't derive enableGenAIFeatures from org, allow disabling it
(:issue:`COMPASS-8680`)
- Adjusts status marker position (:issue:`CLOUDP-289203`)
- Adds tracking for compass-provider (:issue:`COMPASS-8658`)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only for - Adds tracking for compass-provider (:issue:COMPASS-8658) point

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed Adds tracking for compass-provider (:issue:COMPASS-8658). Thanks!

@jmd-mongo jmd-mongo requested a review from mabaasit January 16, 2025 17:20
@jmd-mongo jmd-mongo merged commit 5f67be7 into mongodb:master Jan 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants