-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-45808-atlas-required-roles #707
Conversation
✅ Deploy Preview for docs-compass ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajhuh-mdb LGTM with suggestions. Cheers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Also, I noticed that most of these pages make it look like you need these specific roles to perform these actions in Compass. Are there other changes that will be made to make it clear that these restrictions only apply to Data Explorer? Specifically, there's a notion of control plane roles and data plane roles that I do not want to conflate in our documentation. Compass users do not need these roles in order to execute these actions; only DE users need them. This is an unfortunate reality until control plane and data plane auth are unified
- :authrole:`Project Owner` or :authrole:`Organization Owner` | ||
- :authrole:`Project Data Access Admin` | ||
- :authrole:`Project Data Access Read/Write` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do organization and project owner roles imply that these users are able to do the same things as the other roles? Would it be enough to say "at least" Project Data Access Read/Write
and Project Data Access Admin
? (Genuine question, I'm not sure if there's a standard we need to follow here to also include the owner roles)
This applies to all other relevant places in the PR as well
Required Roles | ||
-------------- | ||
|
||
To :ref:`create <compass-create-index>`, | ||
:ref:`drop <compass-drop-an-index>`, or :ref:`hide <compass-hide-an-index>` | ||
indexes, you must have access provided by at least one of the following roles: | ||
|
||
- :authrole:`Project Owner` or :authrole:`Organization Owner` | ||
- :authrole:`Project Data Access Admin` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible to view indexes with the Project Data Access Read/Write
, Project Data Access Read Only
, and Project Data Access Admin
roles as well. Is that worth calling out separately?
Closing this PR because we've opted to move all the required roles information to the Atlas UI landing page. |
DESCRIPTION
STAGING
JIRA
https://jira.mongodb.org/browse/DOCSP-45808
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?