Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-1910 Remove unused variables and expansions from serverless/create-instance.sh #479

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

kevinAlbs
Copy link
Contributor

Summary

Update .evergreen/serverless/create-instance.sh:

  • Remove check for unused LOADBALANCED environment variable.
  • Remove unused expansions.

Change was verified by running serverless tests with a sample of drivers using this branch:

Go: https://spruce.mongodb.com/version/66c777bde18dda00070cb24d
C#: https://spruce.mongodb.com/version/66cdec53072a2c00077b58be
Java: https://spruce.mongodb.com/version/66cdeb20f6645a000787e3bd

@kevinAlbs kevinAlbs marked this pull request as ready for review August 28, 2024 17:56
@kevinAlbs kevinAlbs requested a review from alcaeus August 28, 2024 17:56
Copy link
Contributor

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll mention that this may cause failures in drivers, but the ticket has been around for long enough now.

@kevinAlbs kevinAlbs merged commit 90dd131 into mongodb-labs:master Sep 3, 2024
45 of 47 checks passed
adriandole pushed a commit to adriandole/drivers-evergreen-tools that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants