Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download correct crypt_shared version when starting serverless instance #459

Merged

Conversation

alcaeus
Copy link
Contributor

@alcaeus alcaeus commented Jul 23, 2024

We currently download the rapid release for serverless, but this is prone to being outdated and needs manual updating. With this change, the serverless create-instance script attempts to download crypt_shared for the matching version. If this version is not available, the setup will fail, indicating there's a problem with the serverless version. Previously, you would sometimes get test failures (for example in CSFLE/QE tests) when versions don't match.

Tested with the PHP driver and confirmed that it downloads MongoDB 8.0 (our serverless instances are running 8.0.0-rc13).

@alcaeus alcaeus requested a review from blink1073 July 23, 2024 10:33
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alcaeus alcaeus merged commit 395efce into mongodb-labs:master Jul 23, 2024
24 checks passed
@alcaeus alcaeus deleted the download-correct-crypt_shared-serverless branch July 23, 2024 12:04
adriandole pushed a commit to adriandole/drivers-evergreen-tools that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants