Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRIVERS-2904 Test against 8.0 builds #438

Merged
merged 2 commits into from
May 3, 2024

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented May 3, 2024

Testing with mongodb/mongo-python-driver#1631

Looking at https://www.mongodb.com/try/download/enterprise, 8.0 supports:

  • MacOS
  • Windows
  • Amazon Linux 2023
  • Debian 12
  • RHEL 8
  • RHEL 9
  • SUSE 15 x64
  • Ubuntu 20
  • Ubuntu 22

@blink1073 blink1073 requested a review from alcaeus May 3, 2024 09:27
@blink1073 blink1073 marked this pull request as ready for review May 3, 2024 09:27
Copy link
Contributor

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@@ -267,14 +277,12 @@ get_mongodb_download_url_for ()
MONGODB_32="http://downloads.mongodb.org/linux/mongodb-linux-x86_64-rhel55${DEBUG}-${VERSION_32}.tgz"
MONGODB_30="http://downloads.mongodb.org/linux/mongodb-linux-x86_64-rhel55${DEBUG}-${VERSION_30}.tgz"
;;
linux-sles-11*-x86_64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted this moved to the bottom of the linux-sles list to be consistent with the ordering of other systems 👍

@@ -388,10 +420,18 @@ get_mongodb_download_url_for ()
MONGODB_50="http://downloads.10gen.com/linux/mongodb-linux-x86_64-enterprise-debian11${DEBUG}-${VERSION_50}.tgz"
# SERVER-62299 Added support for Debian 11 in 5.0.8 and 6.0.0-rc0
;;
linux-debian-12*)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that debian is not sorted in descending order but has too many versions for us to fix in this PR 😅

@@ -56,6 +56,7 @@ get_mongodb_download_url_for ()
VERSION_MONGOSH="2.1.1"
# Set VERSION_RAPID to the latest rapid release each quarter.
VERSION_RAPID="7.3.1"
VERSION_80="v8.0-latest"
VERSION_70="7.0.9"
VERSION_60_LATEST="v6.0-latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant for this PR, but do you remember why we keep 6.0-latest around when we don't have 7.0-latest? Is there a test requirement for 6.0-latest?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the history, I suspect we should have removed it when we added VERSION_60 stable.

@blink1073 blink1073 merged commit a6cfcc8 into mongodb-labs:master May 3, 2024
53 checks passed
@blink1073 blink1073 deleted the DRIVERS-2904 branch May 3, 2024 12:28
adriandole pushed a commit to adriandole/drivers-evergreen-tools that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants