DRIVERS-2616 Fix path handling for Windows #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
NoahStapp
requested changes
Sep 6, 2023
| get_id_token(config) | ||
| config['issuer'] = secrets['oidc_issuer_1_uri'] | ||
| config['username'] = 'test_user1' | ||
| config['token_file'] = os.path.join(token_dir, 'test_user1_expires') | ||
| config['token_file'] = join(token_dir, 'test_user1_expires') |
There was a problem hiding this comment.
There's an extra space here.
| python oidc_get_tokens.py | ||
| ls -ltr $OIDC_TOKEN_DIR |
There was a problem hiding this comment.
What's the purpose of this ls?
There was a problem hiding this comment.
It was for debugging, I'll remove it.
NoahStapp
requested changes
Sep 6, 2023
| @@ -105,6 +105,7 @@ def get_id_token(config=None, expires=None): | |||
| token = response["id_token"] | |||
| if config['token_file']: | |||
| with open(config['token_file'], 'w') as fid: | |||
| print(f"Writing token file: {config['token_file']}") | |||
There was a problem hiding this comment.
Is this intended to be used for debugging?
There was a problem hiding this comment.
Yes, it was too opaque before.
NoahStapp
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with mongodb/mongo-python-driver#1365