DRIVERS-2585 Migrate OIDC Secrets Handling #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
NoahStapp
requested changes
Aug 30, 2023
| secrets = root_get_secrets(["drivers/oidc"], "us-east-1", None)[0] | ||
| for key in list(secrets): | ||
| secrets[key.lower()] = secrets[key] |
There was a problem hiding this comment.
Should this be uppercase to be consistent with other env vars?
There was a problem hiding this comment.
They are used at run time only, I was trying to minimize changes to other files.
NoahStapp
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the OIDC Secrets handling to use the new
setup_secrets.pyscript.Tested in https://spruce.mongodb.com/task/mongo_python_driver_oidc_auth_test__platform~rhel8_python_version~3.9_oidc_auth_test_latest_patch_f2867a9abf277e664b46d3d30dd380e6ae77c9d4_64ee990cc9ec4495336145c5_23_08_30_01_19_18/logs?execution=0.