Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to get debug binaries in get_mongodb_download_url_for #332

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

jddubois
Copy link
Collaborator

This change enables mongosync integration and e2e tests to retrieve debug symbol binaries for testing- these binaries are uploaded to evergreen for easy access. This will improve the debugging experience for the core server team when mongosync exposes server bugs.

Note that not all of these debug URLs are valid, but most are. This change should not have an impact on existing usage of get_mongodb_download_url_for but debug symbols don't seem to exist for some versions and distros.

Copy link
Contributor

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@matthewdale matthewdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jddubois jddubois merged commit efc2751 into master Jul 31, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants