remove abort-controller and address feedback

package.json

@@ -88,7 +88,6 @@
     "xvfb-maybe": "^0.2.1"
   },
   "dependencies": {
-    "abort-controller": "^3.0.0",
     "express": "^4.18.2",
     "open": "^9.1.0",
     "openid-client": "^5.6.4"

src/plugin.spec.ts

@@ -22,7 +22,6 @@ import {
   oktaBrowserAuthCodeFlow,
   oktaBrowserDeviceAuthFlow,
 } from '../test/oidc-test-provider';
-import { AbortController, AbortSignal } from './util';
 import { MongoLogWriter } from 'mongodb-log-writer';
 import { PassThrough } from 'stream';
 import { verifySuccessfulAuthCodeFlowLog } from '../test/log-hook-verification-helpers';
@@ -59,7 +58,7 @@ function requestToken(
   abortSignal?: OIDCAbortSignal
 ): ReturnType<OIDCCallbackFunction> {
   return plugin.mongoClientOptions.authMechanismProperties.OIDC_HUMAN_CALLBACK({
-    timeoutContext: abortSignal ?? new AbortController().signal,
+    timeoutContext: abortSignal,
     version: 1,
     idpInfo: oidcParams,
   });

src/plugin.ts

@@ -8,7 +8,6 @@ import type {
 } from './types';
 import { MongoDBOIDCError } from './types';
 import {
-  AbortController,
   errorString,
   messageFromError,
   normalizeObject,

src/rfc-8252-http-server.spec.ts

@@ -7,7 +7,6 @@ import type { AddressInfo } from 'net';
 import { createConnection } from 'net';
 import type { SinonSandbox } from 'sinon';
 import sinon from 'sinon';
-import { AbortController } from './util';
 import { promisify } from 'util';
 import { randomBytes } from 'crypto';
 

src/types.ts

@@ -99,7 +99,7 @@ export interface IdPServerResponse {
  */
 export interface OIDCCallbackParams {
   refreshToken?: string;
-  timeoutContext: OIDCAbortSignal;
+  timeoutContext?: OIDCAbortSignal;
   version: 1;
   username?: string;
   idpInfo?: IdPServerInfo;

src/util.ts

@@ -45,13 +45,6 @@ export function errorString(err: unknown): string {
   );
 }
 
-export const AbortController =
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
-  globalThis.AbortController ?? require('abort-controller').AbortController;
-export const AbortSignal =
-  // eslint-disable-next-line @typescript-eslint/no-var-requires
-  globalThis.AbortSignal ?? require('abort-controller').AbortSignal;
-
 // AbortSignal.timeout, but consistently .unref()ed
 export function timeoutSignal(ms: number): AbortSignal {
   const controller = new AbortController();