Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-6271): update dev deps and add dependabot config #192

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Aug 8, 2024

Description

What is changing?

Updates dev deps and adds a dependabot config.

For the same reason as outlined in our FLE bindings, this PR doesn't update node-gyp and prebuild because our docker images don't have python3.10 installed, required for the new node-gyp version.

I did try and install python3.10 for a while in our dockerfile, but ran into issues. We're still on the current major version of node-gyp, we should be fine with this version for a while.

(see mongodb-js/mongodb-client-encryption#41)

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title deps chore(NODE-6271): update dev deps and add dependabot config Aug 8, 2024
@baileympearson baileympearson marked this pull request as ready for review August 8, 2024 23:07
package.json Show resolved Hide resolved
@aditi-khare-mongoDB aditi-khare-mongoDB self-assigned this Aug 9, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 9, 2024
@aditi-khare-mongoDB aditi-khare-mongoDB merged commit b13c729 into main Aug 15, 2024
11 checks passed
@aditi-khare-mongoDB aditi-khare-mongoDB deleted the deps branch August 15, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants