fix(NODE-6253): use runtime linking against system kerberos libraries…

… by default (#188)
mongodb-js · Jul 10, 2024 · 04044d2 · 04044d2
1 parent ec3ab7a
commit 04044d2
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/.evergreen/config.yml b/.evergreen/config.yml
@@ -124,7 +124,7 @@ tasks:
     commands:
       - func: run tests ubuntu
         vars:
-          GYP_DEFINES: kerberos_use_rtld=true
+          GYP_DEFINES: kerberos_use_rtld=false
           NPM_OPTIONS: --build-from-source
   - name: run-prebuild
     commands:

diff --git a/.github/scripts/build.mjs b/.github/scripts/build.mjs
@@ -19,7 +19,7 @@ async function parseArguments() {
   const pkg = JSON.parse(await fs.readFile(resolveRoot('package.json'), 'utf8'));
 
   const options = {
-    'kerberos_use_rtld': { type: 'boolean', default: false },
+    'kerberos_use_rtld': { type: 'boolean', default: true },
     help: { short: 'h', type: 'boolean', default: false }
   };
 
@@ -66,8 +66,8 @@ async function buildBindings(args, pkg) {
   // it will also produce `./prebuilds/kerberos-vVERSION-napi-vNAPI_VERSION-OS-ARCH.tar.gz`.
 
   let gypDefines = process.env.GYP_DEFINES ?? '';
-  if (args.kerberos_use_rtld) {
-    gypDefines += ' kerberos_use_rtld=true';
+  if (!args.kerberos_use_rtld) {
+    gypDefines += ' kerberos_use_rtld=false';
   }
 
   gypDefines = gypDefines.trim();

diff --git a/binding.gyp b/binding.gyp
@@ -11,7 +11,7 @@
       ],
       'variables': {
         'ARCH': '<(host_arch)',
-        'kerberos_use_rtld%': 'false'
+        'kerberos_use_rtld%': 'true'
       },
       'xcode_settings': {
         'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',