Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action for builds: Quick QC check for review.tsv #170

Open
3 tasks
Tracked by #164
joeflack4 opened this issue Nov 21, 2024 · 1 comment
Open
3 tasks
Tracked by #164

GitHub Action for builds: Quick QC check for review.tsv #170

joeflack4 opened this issue Nov 21, 2024 · 1 comment
Assignees
Labels

Comments

@joeflack4
Copy link
Contributor

joeflack4 commented Nov 21, 2024

Overview

We recently added a release artefact called review.tsv.

Some of the cases in it are regular and not critical. However, there are other cases which are (much more) unexpected, listed in "critically offending cases" below.

Basically, the build should run, and then the following QC check should execute: Check review.tsv, and if any case classes that are known to be "critically offending" appear, the QC should fail.

This way, we get an email.

Sub-tasks

  • Make goal for QC
  • Have GH action run it at end
  • After completing this, can probably also close: Utilize review.tsv #164

Critically offending cases

@joeflack4 joeflack4 self-assigned this Nov 21, 2024
@joeflack4 joeflack4 added omim qc quality control labels Nov 21, 2024
@twhetzel
Copy link
Contributor

Let's chat before this is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants