-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discuss how to handle "Alternative Titles; symbols" marked as 'formerly' #120
Comments
ExamplesOMIM:153870 OMIM:101400 |
I saw today that Sabrina said:
When the PR for #118 is complete, these will be added verbatim as synonyms. Question:
FYI I also updated examples above, showing how this looks for 1 case of "alternative titles", and 1 case of "included/other" titles. |
yes please
No, I think keeping them as synonyms without any other information is good. |
for the 'formerly' terms in Mondo, I think we usually deprecate them (although it does not seem like this is done consistently), for example: [Term] [Term] |
@nicolevasilevsky in the example you added I see both 'formerly' synonyms marked as |
not all of the synonyms that have (formerly) in the name have been deprecated, is what I meant. I think it makes sense to deprecate them all, as they are no longer used. |
Ok, so any value found in a source, e.g. OMIM, that would be added as a synonym to the source and therefore added to MONDO as a synonym should have:
I see now an example of where this was not done (in addition to ~duplicate synonyms, which is a different problem):
|
from @sabrinatoro on Slack:
|
Hey @nicolevasilevsky, I see the quote from Sabrina but I don't see your response? Just throwing out there that in the synonym sync, we could theoretically only deprecate a synonym if all sources deprecate it, but I would guess that'd be a rare situation, and also not all of our sources are managed through the synonym sync (right now). Maybe will be after externally managed content is finished. |
I haven't had a chance to respond yet, I'll read this more closely and respond shortly |
@sabrinatoro just to clarify- the question is whether we should mark synonyms as DEPCRECATED if they are historic or no longer in use? And there is the question if a synonym is deprecated (or formerly) in OMIM but maybe it is still used by Orphanet in another terminology? I don't really have a strong opinion on how to handle these, I am fine with whatever you all decide. I was just making the point above that we have marked some (formerly) synonyms as DEPRECATED (because they are historic) but not all of them have been marked as such. I think it's a good idea to make a decision about this and be consistent throughout (and be consistent if they are EXACT or RELATED). Let me know if you have further questions for me. (Not sure if I answered everything?) |
Thank you @nicolevasilevsky. You have answered everything. @joeflack4 and @twhetzel What I told you is still correct: bring these "formerly" synonyms as exact synonyms in Mondo. |
Overview
There are some OMIM entries where the values in "Alternative Titles; symbols" are marked as 'formerly'. In the curation call, these values were described as previous names/labels for the OMIM entry. We should discuss how this is being modeled in "omim.owl" and if/what changes are needed to properly represent these as synonyms in Mondo.
Examples: MONDO:0006493, MONDO:0005769
Handling this will be for the next phase of the Synonym Sync project.
See https://omim.org/entry/101000?search=FORMERLY&highlight=formerly
Sub-tasks
, FORMERLY
indicateowl:deprecated
? #155, FORMERLY
#137oio:exactSynonym
&MONDO:omim_formerly
#138The text was updated successfully, but these errors were encountered: