Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsoletion status of xref update #8623

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Obsoletion status of xref update #8623

merged 1 commit into from
Jan 24, 2025

Conversation

twhetzel
Copy link
Collaborator

Update obsoletion status of xrefs.

@twhetzel twhetzel requested a review from sabrinatoro as a code owner January 24, 2025 06:08
twhetzel
twhetzel commented Jan 24, 2025
View reviewed changes
Copy link
Collaborator Author

@twhetzel twhetzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twhetzel twhetzel requested a review from matentzn January 24, 2025 13:29
@katiermullen katiermullen self-assigned this Jan 24, 2025
matentzn
matentzn approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is syntactically correct. I assume you checken the OMIM if has really been obsoleted

@twhetzel
Copy link
Collaborator Author

Yes, I confirmed the OMIM now marked as obsolete is truly obsolete in OMIM.

@twhetzel twhetzel merged commit b579b8a into master Jan 24, 2025
1 check passed
@twhetzel twhetzel deleted the obsoletion_status_xref-bdecdc6 branch January 24, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matentzn matentzn matentzn approved these changes

@sabrinatoro sabrinatoro Awaiting requested review from sabrinatoro sabrinatoro is a code owner

Assignees

@katiermullen katiermullen

Labels
Automated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twhetzel @matentzn @katiermullen