Feat :: cleaned unnecessary classes, codes

Change MutableList to (Immutable)List - Anyway the list is not changing at all. Remove Duplicated Response.kt
molohala · Apr 12, 2024 · 806fb1b · 806fb1b
1 parent 5978173
commit 806fb1b
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 33 deletions.
diff --git a/infinity-api/src/main/kotlin/com/molohala/infinityapi/auth/AuthController.kt b/infinity-api/src/main/kotlin/com/molohala/infinityapi/auth/AuthController.kt
@@ -19,7 +19,7 @@ class AuthController(
     @PostMapping("/sign-in")
     suspend fun signIn(
         @RequestParam("code") @Valid code: String
-    ) = ResponseData.ok("로그인 성공",authService.signIn(code))
+    ) = ResponseData.ok("로그인 성공", authService.signIn(code))
 
     @PostMapping("/reissue")
     fun reissue(

diff --git a/infinity-common/src/main/kotlin/com/molohala/infinitycommon/exception/ErrorResponseEntity.kt b/infinity-common/src/main/kotlin/com/molohala/infinitycommon/exception/ErrorResponseEntity.kt
@@ -14,8 +14,8 @@ data class ErrorResponseEntity(
                 .body(
                     ErrorResponseEntity(
                         status = e.getHttpStatus().value(),
-                        code = e.getExceptionName()!!,
-                        message = e.getMessage()!!
+                        code = e.getExceptionName(),
+                        message = e.getMessage()
                     )
                 )
         }

diff --git a/infinity-core/src/main/kotlin/com/molohala/infinitycore/common/response/Response.kt b/infinity-core/src/main/kotlin/com/molohala/infinitycore/common/response/Response.kt
diff --git a/infinity-core/src/main/kotlin/com/molohala/infinitycore/common/response/ResponseData.kt b/infinity-core/src/main/kotlin/com/molohala/infinitycore/common/response/ResponseData.kt
diff --git a/...c/main/kotlin/com/molohala/infinitycore/community/application/dto/res/CommunityListRes.kt b/...c/main/kotlin/com/molohala/infinitycore/community/application/dto/res/CommunityListRes.kt
@@ -1,8 +1,9 @@
 package com.molohala.infinitycore.community.application.dto.res
 
+import com.querydsl.core.annotations.QueryProjection
 import java.time.LocalDateTime
 
-data class CommunityListRes(
+data class CommunityListRes @QueryProjection constructor(
     val communityId: Long,
     val content: String,
     val createdAt: LocalDateTime,

diff --git a/...c/main/kotlin/com/molohala/infinitycore/community/application/service/CommunityService.kt b/...c/main/kotlin/com/molohala/infinitycore/community/application/service/CommunityService.kt
@@ -35,7 +35,7 @@ class CommunityService(
         )
     }
 
-    fun getList(page: PageRequest): MutableList<CommunityListRes> {
+    fun getList(page: PageRequest): List<CommunityListRes> {
         return queryCommunityRepository.findWithPagination(page)
     }
     fun getById(id: Long) = queryCommunityRepository.findById(id)

diff --git a/...rc/main/kotlin/com/molohala/infinitycore/community/repository/QueryCommunityRepository.kt b/...rc/main/kotlin/com/molohala/infinitycore/community/repository/QueryCommunityRepository.kt
@@ -4,6 +4,6 @@ import com.molohala.infinitycore.common.PageRequest
 import com.molohala.infinitycore.community.application.dto.res.CommunityListRes
 
 interface QueryCommunityRepository {
-    fun findWithPagination(pageRequest: PageRequest):MutableList<CommunityListRes>
+    fun findWithPagination(pageRequest: PageRequest):List<CommunityListRes>
     fun findById(id: Long): CommunityListRes?
 }
diff --git a/...main/kotlin/com/molohala/infinitycore/community/repository/QueryDslCommunityRepository.kt b/...main/kotlin/com/molohala/infinitycore/community/repository/QueryDslCommunityRepository.kt
@@ -18,7 +18,7 @@ class QueryDslCommunityRepository(
     val query: JPAQuery<Community> = queryFactory.select(community)
         .from(community)
 
-    override fun findWithPagination(pageRequest: PageRequest): MutableList<CommunityListRes> {
+    override fun findWithPagination(pageRequest: PageRequest): List<CommunityListRes> {
         return queryFactory
             .select(communityRes())
             .from(community)