-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFER expectations #15
base: master
Are you sure you want to change the base?
Conversation
sfgeorge
commented
Sep 3, 2013
- Add support for expecting and accepting a REFER message.
Ok, to answer my own question, it looks like you're using when responding with a 200 to a REFER, in which case you do not want Also, would you mind adding some tests to cover this new functionality? |
This should probably wait until #34 is merged in a couple of hours. |
Ok, #34 was merged. Please ensure this PR complies with the standards of testing and documentation now in effect on Scenario. |
Pssst... just pinging the project :) |
I think there are two outstanding items on this:
|
Agreed! Regarding point 1, @vindir Can you share any insight you have with problems you had with the REFER dialogue I constructed? |
@sfgeorge By any chance, do you have SIPp scenarios containing a REFER that you can compare to this PR? Can you either confirm that the REFER this code generates is correct, or suggest a change? |
Howdy! Yes, I can sure give an example exchange from Asterisk 1.8 that matches this exchange. Would you recommend any other systems to compare against? |
I'll take whatever examples you've got, but Asterisk 1.8 is a good start. |
@sfgeorge Do you have those examples? Might you be able to rebase this PR so we can get it in to the next version? |
Eek, sorry for the delay. Happy Holidays, Happy New Year and Happy Saint Patrick's Day! 🍀 😄 I can rebase this weekend if that works. What's the best format for an example? I can send you pcap if that would suffice. |
A pcap would be fine :) |
And upgrade test suite to cover Ruby 2.2 & 2.3
Install pcap spec dependency
One test was already failing because it was somehow half-way between the two syntaxes!
This was broken by 893865f.
It is not always necessary and it looks like the next version may not need it at all.
Allow SIPp to be launched without sudo
set event end flag for dtmf digits
Nokogiri update
Hello, |
Hi @pk1057 my foul, I will try to update this PR and share for your and everyone's benefit. Thank you for the reminder! 🎗 |
Hi @sfgeorge, these are great news and i'm eagerly looking forward. |
Loading of the various classes was just a bit broken. 1.1.13 works fine and it supports Ruby 2.4.
PacketFu 1.1.12 didn't really drop PacketFu::UDPPacket
Fix non-writing of PCAP file when media is empty
Robust dtmf packets
[CI] Add CI builds against C-Ruby 2.4, 2.5 and 2.6
Bump Nokogiri dep to address security concern
f25169c
to
3dba3c7
Compare