Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFER expectations #15

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

sfgeorge
Copy link
Contributor

@sfgeorge sfgeorge commented Sep 3, 2013

  • Add support for expecting and accepting a REFER message.

@sfgeorge sfgeorge mentioned this pull request Sep 3, 2013
@bklang
Copy link
Member

bklang commented Sep 3, 2013

Ok, to answer my own question, it looks like you're using when responding with a 200 to a REFER, in which case you do not want rrs.

Also, would you mind adding some tests to cover this new functionality?

@bklang
Copy link
Member

bklang commented Sep 12, 2013

@sfgeorge, when you get a chance: In addition to the tests, I know that @vindir identified some changes to the REFER flow that need to be made in order for it to work successfully. Would the two of you get together and update this PR to include the corrected messages?

@bklang
Copy link
Member

bklang commented Sep 17, 2013

@sfgeorge If you would still like this merged, would you update it so it can be merged? Also, I believe @vindir had a functional change to make to the generated SIPp instructions, in light of our testing with your infrastructure.

@benlangfeld
Copy link
Member

This should probably wait until #34 is merged in a couple of hours.

@benlangfeld
Copy link
Member

Ok, #34 was merged. Please ensure this PR complies with the standards of testing and documentation now in effect on Scenario.

@leifmadsen
Copy link
Contributor

Pssst... just pinging the project :)

@ghost ghost assigned vindir Nov 20, 2013
@bklang
Copy link
Member

bklang commented Nov 20, 2013

I think there are two outstanding items on this:

  • Fix the generated XML for REFER scenarios (this one contains a bug if I recall correctly)
  • Add/update specs to handle the new methods

@sfgeorge
Copy link
Contributor Author

Agreed! Regarding point 1, @vindir Can you share any insight you have with problems you had with the REFER dialogue I constructed?

@bklang
Copy link
Member

bklang commented Oct 7, 2014

@sfgeorge By any chance, do you have SIPp scenarios containing a REFER that you can compare to this PR? Can you either confirm that the REFER this code generates is correct, or suggest a change?

@sfgeorge
Copy link
Contributor Author

sfgeorge commented Oct 9, 2014

Howdy! Yes, I can sure give an example exchange from Asterisk 1.8 that matches this exchange. Would you recommend any other systems to compare against?

@bklang
Copy link
Member

bklang commented Oct 9, 2014

I'll take whatever examples you've got, but Asterisk 1.8 is a good start.

@benlangfeld
Copy link
Member

@sfgeorge Do you have those examples? Might you be able to rebase this PR so we can get it in to the next version?

@sfgeorge
Copy link
Contributor Author

Eek, sorry for the delay. Happy Holidays, Happy New Year and Happy Saint Patrick's Day! 🍀 😄

I can rebase this weekend if that works.

What's the best format for an example? I can send you pcap if that would suffice.

@benlangfeld
Copy link
Member

A pcap would be fine :)

@pk1057
Copy link

pk1057 commented Mar 7, 2018

Hello,
i'm interested to get this feature up and running.
Does an scripting example exist to save me some time during testing ?

@sfgeorge
Copy link
Contributor Author

sfgeorge commented Mar 7, 2018

Hi @pk1057 my foul, I will try to update this PR and share for your and everyone's benefit. Thank you for the reminder! 🎗

@pk1057
Copy link

pk1057 commented Mar 9, 2018

Hi @sfgeorge, these are great news and i'm eagerly looking forward.
If i can help don't hesitate to contact me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants