Deprecate accepting old apostrophe package separator in Mojo::Loader #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grinnz
changed the title
kraih
requested review from
a team,
marcusramberg,
kraih,
jhthorsen and
jberger
|
Do we really need to deprecate this considering it will be removed from Perl? |
|
I have no particular attachment to deprecating it, but it may be a helpful indication before it silently starts treating it as an invalid class name, on all the current Perls where it will still technically be valid. |
|
That said, I would be very surprised if any code relies on this using Mojolicious. |
kraih
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The first commit removes use of the ' package separator in tests, to resolve #2085 (which is now an error in the latest Perl development releases which will remove that feature).
The second commit deprecates calls to Mojo::Loader::load_class that contain a ' package separator.
Motivation
The feature will be removed in upcoming versions of Perl.
References
#2085, Perl/perl5#22504