Mojo::JSON: encode core boolean values as json bools #2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On perl 5.36 and newer, perl's own boolean values can be identified as being booleans. Encode them as JSON boolean values when possible.
haarg
force-pushed
the
json-encode-core-bools
branch
from
425d336
to
2a5e627
Compare
kraih
approved these changes
Aug 9, 2024
kraih
requested review from
a team,
marcusramberg,
jhthorsen,
jberger and
christopherraa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Encode perl's built in boolean values on perl 5.36 and newer
Motivation
Newer perl versions can track if a value is a boolean rather than just a string or number. Since we can identify them as being booleans, they can be encoded in JSON as booleans. This also matches the behavior of newer versions of JSON::PP and Cpanel::JSON::XS
References
Fixes #2191