Fix rubocop issues

.rubocop.yml

@@ -1,3 +1,12 @@
+AllCops:
+  NewCops: enable
+
+Gemspec/RequiredRubyVersion:
+  Enabled: false
+
+Layout/LineLength:
+  Enabled: false
+
 Metrics:
   Enabled: false
 
@@ -13,6 +22,9 @@ Style/Documentation:
 Style/AccessModifierDeclarations:
   Enabled: false
 
+Style/OptionalBooleanParameter:
+  Enabled: false
+
 Style/SafeNavigation:
   Enabled: false
 

deep_cloneable.gemspec

@@ -57,6 +57,7 @@ Gem::Specification.new do |s|
   ]
   s.homepage = 'https://github.com/moiristo/deep_cloneable'
   s.licenses = ['MIT']
+  s.required_ruby_version = '>= 1.9.3'
   s.rubygems_version = '3.0.2'
   s.summary = 'This gem gives every ActiveRecord::Base object the possibility to do a deep clone.'
 

lib/deep_cloneable/deep_clone.rb

@@ -48,11 +48,12 @@ def deep_clone(*args, &block)
             association = association.keys.first
           end
 
-          if conditions_or_deep_associations.is_a?(Hash)
+          case conditions_or_deep_associations
+          when Hash
             conditions_or_deep_associations = conditions_or_deep_associations.dup
             conditions[:if]     = conditions_or_deep_associations.delete(:if)     if conditions_or_deep_associations[:if]
             conditions[:unless] = conditions_or_deep_associations.delete(:unless) if conditions_or_deep_associations[:unless]
-          elsif conditions_or_deep_associations.is_a?(Array)
+          when Array
             conditions_or_deep_associations = conditions_or_deep_associations.dup
             conditions_or_deep_associations.delete_if { |entry| conditions.merge!(entry) if entry.is_a?(Hash) && (entry.key?(:if) || entry.key?(:unless)) }
           end

test/models.rb

@@ -37,7 +37,9 @@ class Ownership < ActiveRecord::Base
 end
 
 class GoldPiece < ActiveRecord::Base;   belongs_to :treasure  end
+
 class Matey < ActiveRecord::Base;       belongs_to :pirate    end
+
 class BattleShip < ActiveRecord::Base;  has_many   :pirates, :as => :ship end
 
 class Parrot < ActiveRecord::Base

test/test_deep_cloneable.rb

@@ -265,7 +265,7 @@ def test_should_deep_clone_with_block
   end
 
   def test_should_deep_clone_with_preprocessor
-    deep_clone = @jack.deep_clone(:include => :parrot, preprocessor: lambda { |original, kopy| kopy.cloned_from_id = original.id })
+    deep_clone = @jack.deep_clone(:include => :parrot, :preprocessor => lambda { |original, kopy| kopy.cloned_from_id = original.id })
 
     assert deep_clone.new_record?
     assert deep_clone.save
@@ -274,7 +274,7 @@ def test_should_deep_clone_with_preprocessor
   end
 
   def test_should_deep_clone_with_postprocessor
-    deep_clone = @jack.deep_clone(:include => :parrot, postprocessor: lambda { |original, kopy| kopy.cloned_from_id = original.id })
+    deep_clone = @jack.deep_clone(:include => :parrot, :postprocessor => lambda { |original, kopy| kopy.cloned_from_id = original.id })
 
     assert deep_clone.new_record?
     assert deep_clone.save

test/test_helper.rb

@@ -15,12 +15,12 @@
 I18n.enforce_available_locales = true
 
 def load_schema
-  config = YAML.load(IO.read(File.dirname(__FILE__) + '/database.yml'))
+  config = YAML.load(IO.read("#{File.dirname(__FILE__)}/database.yml"))
 
   ActiveRecord::Base.logger = if defined?(ActiveSupport::BufferedLogger)
-                                ActiveSupport::BufferedLogger.new(File.dirname(__FILE__) + '/debug.log')
+                                ActiveSupport::BufferedLogger.new("#{File.dirname(__FILE__)}/debug.log")
                               else
-                                ActiveSupport::Logger.new(File.dirname(__FILE__) + '/debug.log')
+                                ActiveSupport::Logger.new("#{File.dirname(__FILE__)}/debug.log")
                               end
 
   db_adapter = ENV['DB']
@@ -29,9 +29,9 @@ def load_schema
   raise 'No DB Adapter selected. Pass the DB= option to pick one, or install Sqlite or Sqlite3.' if db_adapter.nil?
 
   ActiveRecord::Base.establish_connection(config[db_adapter])
-  load(File.dirname(__FILE__) + '/schema.rb')
+  load("#{File.dirname(__FILE__)}/schema.rb")
 end
 
 load_schema
-require File.dirname(__FILE__) + '/../init.rb'
+require "#{File.dirname(__FILE__)}/../init.rb"
 require 'models'