Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Game versions' menu has fixed min height #2334

Open
2 tasks done
w26ad opened this issue Aug 29, 2024 · 0 comments · May be fixed by #2898
Open
2 tasks done

'Game versions' menu has fixed min height #2334

w26ad opened this issue Aug 29, 2024 · 0 comments · May be fixed by #2898
Labels
bug Something isn't working web Relates to Modrinth.com web frontend

Comments

@w26ad
Copy link

w26ad commented Aug 29, 2024

Please confirm the following.

What browsers are you seeing the problem on?

Chrome (including Arc, Brave, Opera, Vivaldi), Microsoft Edge

Describe the bug

image

Steps to reproduce

  1. Go to any project with small amount of versions
  2. Go to Changelog/Versions page
  3. Click 'Game versions' filter menu
  4. See that it has fixed min height set

Expected behavior

It works same as other menus (e.g. 'Channels' menu)

Additional context

No response
@w26ad w26ad added the bug Something isn't working label Aug 29, 2024
@Minenash Minenash added the web Relates to Modrinth.com web frontend label Aug 30, 2024
Erb3 added a commit to Erb3-forked/modrinth that referenced this issue Nov 3, 2024
@Erb3
fix(frontend): remove fixed height from ManySelect
c55be64 
Frontend development is not my passion, there might be a better fix.

I've tested my changes in all places that I found using the chganed components (ManySelect, ScrollablePanel):

- Changelog filters
- Version filters
- Download dialog
- Search filters

Fixes modrinth#2334
@Erb3 Erb3 linked a pull request Nov 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working web Relates to Modrinth.com web frontend
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(frontend): remove fixed height from ManySelect Erb3-forked/modrinth
2 participants
@Minenash @w26ad