Skip to content

Commit

Permalink
fix(frontend): remove fixed height from ManySelect
Browse files Browse the repository at this point in the history
Frontend development is not my passion, there might be a better fix.

I've tested my changes in all places that I found using the chganed components (ManySelect, ScrollablePanel):

- Changelog filters
- Version filters
- Download dialog
- Search filters

Fixes modrinth#2334
  • Loading branch information
Erb3 committed Nov 3, 2024
1 parent e81e056 commit c55be64
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion packages/ui/src/components/base/ManySelect.vue
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"
/>
</div>
<ScrollablePanel v-if="search" class="h-[17rem]">
<ScrollablePanel v-if="search">
<Button
v-for="(option, index) in filteredOptions"
:key="`option-${index}`"
Expand Down
1 change: 1 addition & 0 deletions packages/ui/src/components/base/ScrollablePanel.vue
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ function onScroll({ target: { scrollTop, offsetHeight, scrollHeight } }) {
overflow-y: auto;
overflow-x: hidden;
position: relative;
max-height: 19rem;
::-webkit-scrollbar {
transition: all;
Expand Down

0 comments on commit c55be64

Please sign in to comment.