Skip to content

Commit

Permalink
Switch to explicit Turborepo config
Browse files Browse the repository at this point in the history
This changes Turborepo config in the workspace root to be explicit.
Explicity in this case means that all tasks are defined manually and all
inputs are also specified manually.

While that might seem redundant, this allows to orchestrate and adjust
tasks more carefully - ignoring some files while taking other files into
account, only hashing and providing project-specific variables,
explicitly reviewing and specifying dependencies. That might come in
handy in the future.

There's an alternative way to approach this, which is to have every
package contain "turbo.json" file, however, for now the flat approach
has been chosen as it seems to be the most cleanest and easiest to
review.
  • Loading branch information
brawaru committed Aug 15, 2024
1 parent c7d8c8b commit 7d8ba50
Show file tree
Hide file tree
Showing 3 changed files with 143 additions and 25 deletions.
2 changes: 1 addition & 1 deletion apps/app-frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"version": "0.0.0",
"type": "module",
"scripts": {
"dev": "vite",
"build": "vite build",
"dev": "vite",
"lint": "eslint . && prettier --check .",
"fix": "eslint . --fix && prettier --write ."
},
Expand Down
6 changes: 3 additions & 3 deletions apps/app-playground/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
"name": "@modrinth/app-playground",
"scripts": {
"build": "cargo build --release",
"lint": "cargo fmt --check && cargo clippy -- -D warnings",
"fix": "cargo fmt && cargo clippy --fix",
"dev": "cargo run",
"test": "cargo test"
"test": "cargo test",
"lint": "cargo fmt --check && cargo clippy -- -D warnings",
"fix": "cargo fmt && cargo clippy --fix"
}
}
160 changes: 139 additions & 21 deletions turbo.json
Original file line number Diff line number Diff line change
@@ -1,30 +1,148 @@
{
"$schema": "https://turbo.build/schema.json",
"tasks": {
"build": {
// @modrinth/app
"@modrinth/app#build": {
"dependsOn": ["^build"],
"inputs": ["$TURBO_DEFAULT$", ".env*"],
"outputs": [".nuxt/**", "dist/**", ".output/**", "target/**"],
"env": [
"NODE_ENV",
"SITE_URL",
"BASE_URL",
"FLAG_OVERRIDES",
"BROWSER_BASE_URL",
"RATE_LIMIT_IGNORE_KEY",
"VERCEL_*",
"CF_PAGES_*",
"HEROKU_APP_NAME"
]
"inputs": ["$TURBO_DEFAULT$", "!**/*.md", "!LICENSE"],
"outputs": ["target"]
},
"lint": {},
"dev": {
"@modrinth/app#dev": {
"cache": false,
"persistent": true
},
"@modrinth/app#test": {
"inputs": ["$TURBO_DEFAULT$", "!**/*.md", "!LICENSE"]
},
"@modrinth/app#lint": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},
"@modrinth/app#fix": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},

// @modrinth/app-frontend
"@modrinth/app-frontend#build": {
"dependsOn": ["^build"],
"inputs": ["$TURBO_DEFAULT$", "!**/*.md", "!LICENSE"],
"outputs": ["dist"],
"env": ["BASE_URL", "BROWSER_BASE_URL"]
},
"@modrinth/app-frontend#dev": {
"cache": false,
"persistent": true,
"env": [
"*"
]
"env": ["BASE_URL", "BROWSER_BASE_URL"]
},
"@modrinth/app-frontend#lint": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},
"@modrinth/app-frontend#fix": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},

// @modrinth/app-playground
"@modrinth/app-playground#build": {
"dependsOn": ["^build"],
"inputs": ["$TURBO_DEFAULT$", "!**/*.md", "!LICENSE"],
"outputs": ["target"]
},
"@modrinth/app-playground#dev": {
"cache": false,
"persistent": true
},
"@modrinth/app-playground#test": {
"inputs": ["$TURBO_DEFAULT$", "!**/*.md", "!LICENSE"]
},
"@modrinth/app-playground#lint": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},
"@modrinth/app-playground#fix": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},

// @modrinth/frontend
"@modrinth/frontend#build": {
"dependsOn": ["^build"],
"inputs": ["$TURBO_DEFAULT$", "!*.md", "!LICENSE", "!src/generated"],
"outputs": [".nuxt", ".output", "src/generated"],
"env": ["BASE_URL", "BROWSER_BASE_URL", "RATE_LIMIT_IGNORE_KEY", "SITE_URL", "FLAG_OVERRIDES"]
},
"test": {}
}
"@modrinth/frontend#dev": {
"cache": false,
"persistent": true,
"env": ["BASE_URL", "BROWSER_BASE_URL", "RATE_LIMIT_IGNORE_KEY", "SITE_URL", "FLAG_OVERRIDES"]
},
"@modrinth/frontend#preview": {
"dependsOn": ["build"],
"inputs": [".output"]
},
"@modrinth/frontend#lint": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},
"@modrinth/frontend#fix": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},
"@modrinth/frontend#intl:extract": {
"inputs": [
"src/**/*.vue",
"src/**/*.ts",
"src/**/*.tsx",
"src/**/*.js",
"src/**/*.jsx",
"src/**/*.mts",
"src/**/*.cts",
"src/**/*.mjs",
"src/**/*.cjs",
"!src/**/*.d.ts"
],
"outputs": ["src/locales/en-US/index.json"]
},

// @modrinth/app-lib
"@modrinth/app-lib#build": {
"inputs": ["$TURBO_DEFAULT$", "!**/*.md", "!LICENSE"],
"outputs": ["target"]
},
"@modrinth/app-lib#lint": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},
"@modrinth/app-lib#fix": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},
"@modrinth/app-lib#test": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},

// @modrinth/assets
"@modrinth/assets#lint": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},
"@modrinth/assets#fix": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},

// @modrinth/ui
"@modrinth/ui#lint": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},
"@modrinth/ui#fix": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},

// @modrinth/utils
"@modrinth/utils#lint": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},
"@modrinth/utils#fix": {
"inputs": ["$TURBO_DEFAULT$", "!LICENSE"]
},

"build": {},
"dev": {},
"test": {},
"lint": {},
"fix": {},
"intl:extract": {}
},
"globalEnv": ["NODE_ENV", "TAURI_*", "VERCEL_*", "HEROKU_*", "CF_PAGES_*"]
}

0 comments on commit 7d8ba50

Please sign in to comment.