Support for kali linux + fixing amavis dependency issue #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonioo
reviewed
Jun 17, 2024
| @@ -17,7 +17,7 @@ class Amavis(base.Installer): | |||
| packages = { | |||
| "deb": [ | |||
| "libdbi-perl", "amavisd-new", "arc", "arj", "cabextract", | |||
| "liblz4-tool", "lrzip", "lzop", "p7zip-full", "rpm2cpio", | |||
| "lz4", "lrzip", "lzop", "p7zip-full", "rpm2cpio", | |||
There was a problem hiding this comment.
Are you sure changing this package name has no impact on the other distributions?
There was a problem hiding this comment.
As far as I understand all those are Debian derivatives and the naming should be the same, I will create a few VMs with Debian and Ubuntu and verify.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Installation now supports kali linux and does not error with amavis dependency issue
Desired behavior after PR is merged:
Installation finishes OK and I can drink coffee instead of babysitting it