Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(multiple): fix failing tests #2338

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Oct 17, 2024

Fix tests whose failures were suppressed before #2335:

  • skip snapshot on mac for test_mp7.py::test_mp7_output, mp7 results differ slightly for some reason
  • fix the venv bin/lib directory names on Windows in test_generate_classes.py

@wpbonelli wpbonelli added this to the 3.9 milestone Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.2%. Comparing base (5555d15) to head (f270662).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2338     +/-   ##
=========================================
- Coverage     74.3%   74.2%   -0.2%     
=========================================
  Files          294     294             
  Lines        59562   59749    +187     
=========================================
+ Hits         44282   44360     +78     
- Misses       15280   15389    +109     

see 17 files with indirect coverage changes

@wpbonelli wpbonelli marked this pull request as ready for review October 17, 2024 19:24
@wpbonelli wpbonelli merged commit e85ecd2 into modflowpy:develop Oct 17, 2024
23 checks passed
@wpbonelli wpbonelli deleted the fix-tests branch October 17, 2024 19:24
@wpbonelli wpbonelli added the bug label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant