Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(get-modflow): allow specifying repo owner #1910

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Aug 8, 2023

  • support --owner cli option and corresponding run_main() (and other fn) params
  • document owner option in get_modflow.md
  • expand tests

This allows installing from releases posted on e.g. personal forks of modflow6. For instance, after this PR, to install the PRT development build:

get-modflow : --owner aprovost-usgs --repo modflow6

* support --owner arg and corresponding params on run_main() and other fns
* update tests to allow configuring multiple owners (e.g. personal forks)
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #1910 (57bf4e5) into develop (c25c0b3) will decrease coverage by 0.1%.
The diff coverage is 81.8%.

@@            Coverage Diff            @@
##           develop   #1910     +/-   ##
=========================================
- Coverage     72.5%   72.5%   -0.1%     
=========================================
  Files          257     257             
  Lines        56261   56267      +6     
=========================================
- Hits         40843   40842      -1     
- Misses       15418   15425      +7     
Files Changed Coverage Δ
flopy/utils/get_modflow.py 63.7% <81.8%> (-0.2%) ⬇️

... and 1 file with indirect coverage changes

@wpbonelli wpbonelli marked this pull request as ready for review August 8, 2023 12:50
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, @w-bonelli

@wpbonelli wpbonelli merged commit 1cb7594 into modflowpy:develop Aug 8, 2023
21 checks passed
@wpbonelli wpbonelli deleted the get-modflow branch August 8, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants