Raise custom SynchronizerShutdown from ongoing calls when synchronizer shuts down #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loop In case we are inside the loop we instead propagate asyncio.CancelledErrors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to more easily disambiguate user errors that result in
asyncio.CancelledErrororconcurrent.futures.CancelledErrorfrom those that are emitted by synchronicity itself when it shuts down.While this does the job, it might make sense to listen to some event
event_loop_shutdown_imminentin our wrapper calls instead (or additionally) and trigger that signal first, to allow further async calls on the event loop for cleanup before the loop actually shuts down. Filing that for a future improvement :)