Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proto changes for pty-shell resizing #2820

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add proto changes for pty-shell resizing #2820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions modal_proto/api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2180,6 +2180,9 @@ message RuntimeInputMessage {
bytes message = 1;
uint64 message_index = 2;
bool eof = 3;
// only used to handle `container exec` terminal resize events
optional uint32 window_rows = 4;
optional uint32 window_cols = 5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • maybe we should comment that window_rows and window_cols are only used for container exec?
  • do you think window_rows or terminal_rows or pty_rows is clearer? (feel free to keep as window_rows if you think that makes more sense to you)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no strong preference on the naming! willing to defer to anyone else who has a strong opinion on what this field should look like

}

message RuntimeOutputBatch {
Expand Down
Loading