Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename proto: enable_memory_snapshot -> enable_snapshot #2779

Merged
merged 1 commit into from
Jan 17, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions modal_proto/api.proto
Original file line number Diff line number Diff line change
Expand Up @@ -2228,8 +2228,9 @@ message Sandbox {

optional string proxy_id = 23;

// Enable memory snapshots.
bool enable_memory_snapshot = 24;
// Enable snapshotting the sandbox (both memory and filesystem).
// This doesn't need to be enabled to save the filesystem as an image (i.e. a filesystem-only snapshot).
bool enable_snapshot = 24;

// Used to pin gVisor version for memory-snapshottable sandboxes.
// This field is set by the server, not the client.
Expand Down
Loading