Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a bunch of static typing issues in modal.object [CLI-312] #2771

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

freider
Copy link
Contributor

@freider freider commented Jan 17, 2025

  • Splits object.py into _object.py with implemenation and object.py with synchronicity wrappers
  • Fixes a lot of type errors that surfaced as a result

Describe your changes

  • Provide Linear issue reference (e.g. MOD-1234) if available.
Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

  • Internal refactor of the modal.object module. All entities except Object from that module have now been moved to the modal._object "private" module.

@freider freider requested a review from mwaskom January 17, 2025 12:15
* Splits object.py into _object.py with implemenation and object.py with synchronicity wrappers
* Fixes a lot of type errors that surfaced as a result
@freider freider force-pushed the freider/object-type-fixes branch from 12f2741 to 53f2afa Compare January 17, 2025 12:19
@freider
Copy link
Contributor Author

freider commented Jan 17, 2025

I split the work into two commits to make reviewing a bit easier - the first one just renames object.py -> _object.py, and the second one applies all of the actual changes

@freider freider changed the title Fixes a bunch of static typing issues in modal.object Fixes a bunch of static typing issues in modal.object [CLI-312] Jan 17, 2025
@erikbern
Copy link
Contributor

🆒

@freider
Copy link
Contributor Author

freider commented Jan 17, 2025

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @mwaskom will follow-up review this.

@freider freider merged commit 690aa85 into main Jan 17, 2025
23 checks passed
@freider freider deleted the freider/object-type-fixes branch January 17, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants