Expose Object.hydrate as public API / deprecate Object.resolve #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops meant to abandon #2770, not this one! |
mwaskom
force-pushed
the
michael/2025-01-15-object-hydrate-method
branch
from
8899c10 to
495f365
Compare
mwaskom
force-pushed
the
michael/2025-01-15-object-hydrate-method
branch
from
493ff48 to
ab3cb55
Compare
mwaskom
force-pushed
the
michael/2025-01-15-object-hydrate-method
branch
from
ab3cb55 to
8051d9c
Compare
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
freider
reviewed
Jan 22, 2025
| @@ -517,8 +517,9 @@ async def exec( | |||
| raise InvalidError(f"workdir must be an absolute path, got: {workdir}") | |||
|
|
|||
| # Force secret resolution so we can pass the secret IDs to the backend. | |||
| # TODO should we parallelize this? | |||
There was a problem hiding this comment.
Yes! cries in eu latencies
freider
reviewed
Jan 22, 2025
| elif not self._hydrate_lazily: | ||
| # TODO(michael) can remove _hydrate lazily? I think all objects support it now? |
There was a problem hiding this comment.
Everything except locally defined Functions and Classes (as defined by the function and cls decorators)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We are deprecating the
Object.lookupmethod, which eagerly hydrates the object upon construction, in favor of the following pattern:Object.from_nameand rely on operations triggering on-demand hydrationObject.hydrate()method.The
.hydratemethod replaces the existing.resolvemethod. The new name was introduced because we have more commonly used "hydration" terminology (i.e. in error messages) and it is more accurate given the current Modal object model. The new method is marginally more user-friendly, e.g. it returns self so it can be called fluently.Part of CLI-96
Backward/forward compatibility checks
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
Changelog
.hydrate, for on-demand hydration of Modal objects. This method replaces the existing semi-public.resolvemethod, which is now deprecated.