Code

Client now retries .map() failures#2734

Code

Open

rculbertson wants to merge 19 commits intomainmodal-labs/modal-client:mainfrom ryan/retry-mapmodal-labs/modal-client:ryan/retry-mapCopy head branch name to clipboard

+326-41

Commits

Commits on Jan 28, 2025

• Add attempt number input item proto

  rculbertson

  committed
  371d622

  Copy full SHA for 371d622

• Rename field to retry_count

  rculbertson

  committed
  a2a36f5

  Copy full SHA for a2a36f5

• Add client retry support to .map

  

  rohansingh

  authored and

  rculbertson

  committed
  75d882a

  Copy full SHA for 75d882a

• Track in-flight inputs by idx instead of input_id

  

  rohansingh

  authored and

  rculbertson

  committed
  0cc784c

  Copy full SHA for 0cc784c

• Fix TimedPriorityQueue to work with duplicate timestamps

  Show description for 05091e8
  

  rohansingh

  authored and

  rculbertson

  committed
  05091e8

  Copy full SHA for 05091e8

• Add unit tests for map retries

  

  rohansingh

  authored and

  rculbertson

  committed
  2226489

  Copy full SHA for 2226489

• Respect MODAL_CLIENT_RETRIES setting for map

  

  rohansingh

  authored and

  rculbertson

  committed
  e72c7fb

  Copy full SHA for e72c7fb

• Fix race condition between inputs/outputs

  Show description for 1066434
  

  rohansingh

  authored and

  rculbertson

  committed
  1066434

  Copy full SHA for 1066434

• Fix deadlocks on large numbers of inputs

  Show description for ba4937a
  

  rohansingh

  authored and

  rculbertson

  committed
  ba4937a

  Copy full SHA for ba4937a

• Simplify implementation

  Show description for 1886b01
  

  rohansingh

  authored and

  rculbertson

  committed
  1886b01

  Copy full SHA for 1886b01

• wip map retries

  rculbertson

  committed
  a7f808f

  Copy full SHA for a7f808f

• More fixes

  rculbertson

  committed
  a73b4ee

  Copy full SHA for a73b4ee

• Make compatible with 3.9

  rculbertson

  committed
  fcac50a

  Copy full SHA for fcac50a

• Add tests and remove busy wait from queue

  rculbertson

  committed
  266dc7f

  Copy full SHA for 266dc7f

• Remove debug logging

  rculbertson

  committed
  bda4590

  Copy full SHA for bda4590

• Guard against duplicate outputs

  rculbertson

  committed
  94e919c

  Copy full SHA for 94e919c

• Add attempt number

  rculbertson

  committed
  79bafd4

  Copy full SHA for 79bafd4

• Rename field to retry_count

  rculbertson

  committed
  72dfb40

  Copy full SHA for 72dfb40

• Remove debug code

  rculbertson

  committed
  d566f20

  Copy full SHA for d566f20