include sha256_hex in MountPutFile response #2722
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare for making it optional to pass in the sha256_hex in the request
danielnorberg
added a commit
that referenced
this pull request
Jan 4, 2025
Let the backend return the resulting sha256 hash instead of computing it up front. Requires #2722 and corresponding internal change to make sha256_hex optional in the MountPutFile handler.
2 tasks
danielnorberg
added a commit
that referenced
this pull request
Jan 4, 2025
Let the backend return the resulting sha256 hash instead of computing it up front. Requires #2722 and corresponding internal change to make sha256_hex optional in the MountPutFile handler.
danielnorberg
added a commit
that referenced
this pull request
Jan 4, 2025
Let the backend return the resulting sha256 hash instead of computing it up front. Requires #2722 and corresponding internal change to make sha256_hex optional in the MountPutFile handler.
danielnorberg
added a commit
that referenced
this pull request
Jan 4, 2025
Let the backend return the resulting sha256 hash instead of computing it up front. Requires #2722 and corresponding internal change to make sha256_hex optional in the MountPutFile handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for making it optional to pass in the sha256_hex in the request.
Describe your changes
Backward/forward compatibility checks
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
Changelog