Add types to modal_version and modal_utils

[savarin]

Describe your changes

This PR adds mypy types to modal_version and modal_utils, as per #1372.

modal_utils/__init__.py
modal_utils/app_utils.py
modal_utils/async_utils.py
modal_utils/grpc_testing.py
modal_utils/grpc_utils.py
modal_utils/hash_utils.py
modal_utils/http_utils.py
modal_utils/logger.py
modal_utils/package_utils.py
modal_utils/rand_pb_testing.py
modal_version/__init__.py
modal_version/_version_generated.py

[modal-pr-review-automation]

Auto-approved 👍. This diff qualified for automatic approval and doesn't need follow up review.

[savarin]

@freider I'm a little puzzled why this now raises a mypy error, since unary_stream returns AsyncIterator[_RecvType].

modal-client/modal_utils/grpc_utils.py

Line 205 in 83e90f2

) -> AsyncIterator[_RecvType]:

Not sure why this isn't picked up in functions.py.

[freider]

I think it's due to --follow-imports=skip, so the imported type isn't available (removing that flag, this error disappears but you get tons of errors in the imported files instead...). I wonder if there is a way to check a single file for type errors but still follow imports in order to get types

[freider]

Would prefer not to have unnecessary # type: ignores in places just because mypy can't properly traverse things. The only case I think we should need it is when a .py-file references a type that's only defined in the same file's .pyi file, since I doubt we can get mypy to actually read both

[freider]

I updated the repo to use pyright instead of mypy for checking implemenation files, since mypy seems basically broken in this regard. See: #1403

[savarin]

I updated the repo to use pyright instead of mypy for checking implemenation files, since mypy seems basically broken in this regard. See: #1403

@freider Sounds good! Sorry for delay, had been away last week and into this week. I'll take a look at #1403.

[freider]

I updated the repo to use pyright instead of mypy for checking implemenation files, since mypy seems basically broken in this regard. See: #1403

@freider Sounds good! Sorry for delay, had been away last week and into this week. I'll take a look at #1403.

Just merged #1403 so it should be straight-forward to take on typing fixes for additional files now if you want to :)

[savarin]

Just merged #1403 so it should be straight-forward to take on typing fixes for additional files now if you want to :)

@freider Thanks for the heavy lifting! I'm afraid I haven't gotten the chance to take a closer look at pyright (or at least don't completely follow errors) but can move tad slower and go for the low hanging fruit first as I feel my way around - created #1438 to keep things moving.