Skip to content

Commit

Permalink
removed constructor that takes a margo instance
Browse files Browse the repository at this point in the history
  • Loading branch information
mdorier committed Nov 30, 2023
1 parent d75c6e1 commit 7b78d2a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 18 deletions.
13 changes: 0 additions & 13 deletions include/alpha/Provider.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,6 @@ class Provider {
const std::string& config,
const tl::pool& pool = tl::pool());

/**
* @brief Constructor.
*
* @param mid Margo instance id to use to receive RPCs.
* @param provider_id Provider id.
* @param config JSON-formatted configuration.
* @param pool Argobots pool to use to handle RPCs.
*/
Provider(margo_instance_id mid,
uint16_t provider_id,
const std::string& config,
const tl::pool& pool = tl::pool());

/**
* @brief Copy-constructor is deleted.
*/
Expand Down
5 changes: 0 additions & 5 deletions src/Provider.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,6 @@ Provider::Provider(const tl::engine& engine, uint16_t provider_id, const std::st
self->get_engine().push_finalize_callback(this, [p=this]() { p->self.reset(); });
}

Provider::Provider(margo_instance_id mid, uint16_t provider_id, const std::string& config, const tl::pool& p)
: self(std::make_shared<ProviderImpl>(mid, provider_id, config, p)) {
self->get_engine().push_finalize_callback(this, [p=this]() { p->self.reset(); });
}

Provider::Provider(Provider&& other) {
other.self->get_engine().pop_finalize_callback(this);
self = std::move(other.self);
Expand Down

0 comments on commit 7b78d2a

Please sign in to comment.