Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix monitoring when adding pools #274

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

mdorier
Copy link
Contributor

@mdorier mdorier commented Jun 28, 2024

This PR fixes a bug that happens if we add a pool when monitoring (in particular time series) is enabled. The current problem is that because there is no time series structure allocated for the new pool, the default monitoring system will access an array out of range, causing a segfault.

To solve this problem, this PR makes the following changes:

  • It adds monitoring callbacks invoked when pools and xstreams are added and removed, to give a chance for the monitoring framework (whether default or custom) to react to such a change (e.g. by allocating/deallocating the proper data structures);
  • It implements these callbacks for the default monitoring framework, allocating and moving the the time series as appropriate when a pool is added/removed.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 50.38760% with 64 lines in your changes missing coverage. Please review.

Project coverage is 57.24%. Comparing base (7682c08) to head (54d3cf5).

Files Patch % Lines
src/margo-default-monitoring.c 0.00% 37 Missing ⚠️
src/margo-config.c 70.65% 22 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
- Coverage   57.41%   57.24%   -0.18%     
==========================================
  Files          69       69              
  Lines        9626     9735     +109     
  Branches     1252     1256       +4     
==========================================
+ Hits         5527     5573      +46     
- Misses       3332     3394      +62     
- Partials      767      768       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdorier mdorier merged commit 9c6056c into main Jun 28, 2024
5 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants