-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: highlight browser failures #5222
base: main
Are you sure you want to change the base?
feat: highlight browser failures #5222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks for the overhaul! ✨
Just requesting undoing unrelated changes, to make it easier to review & not take up as much of a diff.
This reverts commit 8552a91.
@JoshuaKGoldberg, ready for review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks for iterating on it & coming up with good ideas! 🙌
Approved - and will leave open for a bit in case anybody from @mochajs/maintenance-crew has time & interest to review.
PR Checklist
status: accepting prs
Overview
skip
for root suite will showpass
for simplicity (happy to change)